Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verkle: implement verkle proof verification #3423

Merged
merged 20 commits into from
May 17, 2024
Merged

verkle: implement verkle proof verification #3423

merged 20 commits into from
May 17, 2024

Conversation

gabrocheleau
Copy link
Contributor

No description provided.

@gabrocheleau gabrocheleau requested review from acolytec3 and removed request for acolytec3 May 15, 2024 09:10
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.65%. Comparing base (d24ca11) to head (c592469).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 80.78% <ø> (?)
blockchain 90.97% <ø> (ø)
client 84.39% <87.50%> (?)
common ?
devp2p 81.85% <ø> (?)
evm 73.70% <ø> (?)
genesis 99.98% <ø> (?)
statemanager ?
trie 59.63% <ø> (?)
tx 85.93% <ø> (?)
util ?

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 previously approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far. Are we going to do a separate PR to add proof verification in the client?

@gabrocheleau gabrocheleau marked this pull request as ready for review May 16, 2024 12:03
@gabrocheleau gabrocheleau requested a review from acolytec3 May 16, 2024 17:38
acolytec3
acolytec3 reviewed May 16, 2024
View reviewed changes
packages/vm/src/runBlock.ts
Comment on lines +142 to +147
// Update the stateRoot cache
await stateManager.setStateRoot(block.header.stateRoot)

// Populate the execution witness
stateManager.initVerkleExecutionWitness(block.header.number, block.executionWitness)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this below the error condition checks or do they need to happen before we check for parent stateRoot?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I moved this up

acolytec3
acolytec3 previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to go ahead and approve. One nit but I don't know if it's even a valid concern.

@acolytec3 acolytec3 merged commit c95499c into master May 17, 2024
35 of 36 checks passed
@holgerd77 holgerd77 deleted the verkle/verify-proof branch May 17, 2024 13:25
g11tech
g11tech reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, post merge review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech left review comments

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: client package: statemanager package: verkle package: vm PR state: needs review type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrocheleau @acolytec3 @g11tech