-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
monorepo: remove EIP 2315 (JUMPSUB) #3342
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gonna go ahead and merge here. I think we could try optimizing |
This PR removes EIP 2315. The opcodes have been reclaimed by TSTOREs/TLOADs
TODO: check if we can now optimize
runState.validJumps[dest] === 1
(do we have any other cases of a valid JUMP or not?)