-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trie: use Uint8Array as value type in DB #3067
Changes from all commits
730bfd9
55632fa
8b8376f
546a151
a0b9073
421fbe4
561b78c
0f9e39f
53767ee
d361eb8
8cff6f8
e3bdb7c
7f9ede3
821f1ca
f2000db
dbbc082
4e41cba
d4675c9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -334,6 +334,14 @@ const args: ClientOpts = yargs(hideBin(process.argv)) | |
deprecated: | ||
'Support for `--prefixStorageTrieKeys=false` is temporary. Please sync new instances with `prefixStorageTrieKeys` enabled', | ||
}) | ||
.options('useStringValueTrieDB', { | ||
describe: | ||
'Use string values in the trie DB. This is old behavior, new behavior uses Uint8Arrays in the DB (more performant)', | ||
boolean: true, | ||
default: false, | ||
deprecated: | ||
'Usage of old DBs which uses string-values is temporary. Please sync new instances without this option.', | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No big deal, but I think we should rather use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, good point, so it is not being confused with a blocks DB or anything 😄 |
||
.option('txLookupLimit', { | ||
describe: | ||
'Number of recent blocks to maintain transactions index for (default = about one year, 0 = entire chain)', | ||
|
@@ -876,6 +884,7 @@ async function run() { | |
disableBeaconSync: args.disableBeaconSync, | ||
forceSnapSync: args.forceSnapSync, | ||
prefixStorageTrieKeys: args.prefixStorageTrieKeys, | ||
useStringValueTrieDB: args.useStringValueTrieDB, | ||
txLookupLimit: args.txLookupLimit, | ||
pruneEngineCache: args.pruneEngineCache, | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. 🙂👍