-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx
tree shaking opportunity -> TxFactory
#3485
Comments
I'm not entirely sure why this is breaking? |
This substantially changes how a |
Instead of doing something like import { fromTxData } from '@ethereumjs/tx'`
//...
const tx = await fromTxData(...txData) We could consider an alternative approach which is a single |
tx
tree shaking opportunitytx
tree shaking opportunity -> TxFactory
One thing to note here, I think this also goes very much along with #3487 and one thing to make sure is that the respective tx type specific not-used So if e.g. |
Part of #3446
Earliest start together with official breaking release work!
One small opportunity for tree shaking is to convert the existing
TxFactory
class into a series of single functions that are exported from thetx
package or something similar. The class itself serves no essential purpose beyond offering an entry point to the transaction factory. We should pick this up when we get into tree shaking.The text was updated successfully, but these errors were encountered: