Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie: Options dict for constructor options #1843

Closed
holgerd77 opened this issue Apr 7, 2022 · 2 comments
Closed

Trie: Options dict for constructor options #1843

holgerd77 opened this issue Apr 7, 2022 · 2 comments

Comments

@holgerd77
Copy link
Member

While most libraries in the monorepo take in an options dict with the available options in the constructor - e.g. the VM, Tx or the Block library - the Trie library still takes (its currently 2) options one-by-one.

This should be updated on develop so that all flavors of Trie (Base, CP, Secure) take in the two options as a typed dictionary together with a new options type interface in a dedicated src/types.ts file.

@holgerd77
Copy link
Member Author

(so the reason for this is that it makes the constructor options more easily extendable by removing the need of chaining additional options as main parameters in the constructor, also get's easier to e.g. deprecate or rename options)

@holgerd77
Copy link
Member Author

Closed by #1874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant