Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Testing Strategy #21

Closed
3 tasks done
holgerd77 opened this issue May 29, 2018 · 4 comments
Closed
3 tasks done

Testing Strategy #21

holgerd77 opened this issue May 29, 2018 · 4 comments
Labels

Comments

@holgerd77
Copy link
Member

holgerd77 commented May 29, 2018

Description

This library is currently completely untested, there is just a stub test file in the tests folder allowing for the basic CI setup, which is already running.

While most of the module functionality is tested in the different EthereumJS repositories like ethereumjs-blockchain, ethereumjs-block or ethereumjs-devp2p, there have to be integration tests testing the interplay of the different modules in the client context as well as the CL entrypoints of the client.

Possible Implementation

Some ideas for tests, partly taken from py-EVM:

  • DB and directory initialization tests
  • CLI option tests, undefined behaviour
  • RPC method tests

Reference Implementations / Links

@fgimenez
Copy link
Contributor

fgimenez commented Jun 1, 2018

I'd like to work on the first task, DB and directory initialization tests, if anyone else is at it, hope to have something ready soon :)

@holgerd77
Copy link
Member Author

Cool! 👍

@aunyks
Copy link
Contributor

aunyks commented Dec 5, 2018

Is this still an issue or can it be closed?

@vpulim
Copy link
Contributor

vpulim commented Dec 6, 2018

This can probably be closed since I finished writing all the unit tests that get us to over 90% coverage in #70. I would still like to see some integration tests done to make sure components are working together correctly. I've created a new issue for this: #73 so we can close down this one.

@vpulim vpulim closed this as completed Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants