Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only try to resolve ENS names on mainnet (in the default middleware) #887

Closed
1 of 3 tasks
carver opened this issue Jun 5, 2018 · 7 comments
Closed
1 of 3 tasks

Comments

@carver
Copy link
Collaborator

carver commented Jun 5, 2018

What was wrong?

The ENS middleware will try to resolve names no matter what your network ID. Test chains shouldn't try to resolve these names, and give confusing errors when you accidentally supply a name-like value to an address field.

How can it be fixed?

  • Modify the ens middleware to initialize with a network ID and only attempt to resolve names if connected to that network ID.
  • When validating whether a value is acceptable input for an address, only accept an ENS name if connected to the correct network ID.
  • Set up the default middleware to use network ID 1 (for mainnet).
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 180.0 DAI (180.0 USD @ $1.0/DAI) attached to it.

@voith
Copy link
Contributor

voith commented Aug 30, 2018

for anyone starting on this, read #883 (comment) and #870 to understand what goes wrong when ens tries to resolve names when connected to a testnet.

@gitcoinbot
Copy link

gitcoinbot commented Aug 30, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months, 3 weeks from now.
Please review their action plans below:

  1. ankitchiplunkar has been approved to start work.

    Would update the ens middleware.
    Would add relevant tests and docs.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 180.0 DAI (180.0 USD @ $1.0/DAI) has been submitted by:

  1. @ankitchiplunkar

@vs77bb please take a look at the submitted work:


@ankitchiplunkar
Copy link
Contributor

@vs77bb the PR has been merged

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 180.0 DAI (180.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @ankitchiplunkar.

@wolovim
Copy link
Member

wolovim commented Jun 1, 2020

Cleaning up stale issues; the work was done, issue didn't get closed with it.

@wolovim wolovim closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants