-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only try to resolve ENS names on mainnet (in the default middleware) #887
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 180.0 DAI (180.0 USD @ $1.0/DAI) attached to it.
|
for anyone starting on this, read #883 (comment) and #870 to understand what goes wrong when ens tries to resolve names when connected to a testnet. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 11 months, 3 weeks from now.
Learn more on the Gitcoin Issue Details page. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 180.0 DAI (180.0 USD @ $1.0/DAI) has been submitted by: @vs77bb please take a look at the submitted work:
|
@vs77bb the PR has been merged |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 180.0 DAI (180.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @ankitchiplunkar.
|
Cleaning up stale issues; the work was done, issue didn't get closed with it. |
What was wrong?
The ENS middleware will try to resolve names no matter what your network ID. Test chains shouldn't try to resolve these names, and give confusing errors when you accidentally supply a name-like value to an address field.
How can it be fixed?
The text was updated successfully, but these errors were encountered: