Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filtering by pending blocks #3384

Open
kclowes opened this issue May 8, 2024 · 1 comment
Open

Remove filtering by pending blocks #3384

kclowes opened this issue May 8, 2024 · 1 comment
Labels

Comments

@kclowes
Copy link
Collaborator

kclowes commented May 8, 2024

What feature should we add?

Geth has removed the ability to filter by pending blocks. Reasoning from Geth 1.14.0 release notes here:

We see next to no value in monitoring the logs of a random subset of transactions that might (but probably mostly will not) end up in the next block. Power users who wish to monitor the transaction pool for MEV (or similar) purposes, should hook into Geth directly and extract the exact data they need, rather than rely on insufficient API endpoints.

I think we can fairly safely remove it too. TBD if this needs to go in v7 before breaking changes are wrapped.

@pacrob
Copy link
Contributor

pacrob commented Dec 2, 2024

Seems like this should be considered breaking, even if the endpoint isn't actually that useful. Adding to v8 stuff.

@pacrob pacrob added Breaking Change v8 breaking changes for v8 labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants