Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper pin to eth-account in anticipation of breaking changes #3339

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Apr 12, 2024

What was wrong?

eth-account v0.13 will have some breaking changes for web3 v6 (mainly camelCase -> snake_case changes). Pinning here before 0.13 gets released so we don't run into problems.

How was it fixed?

Pinned it!

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the upper-pin-eth-account branch from 9ef2ca1 to 0792d95 Compare April 12, 2024 16:28
@kclowes kclowes marked this pull request as ready for review April 12, 2024 16:36
@kclowes kclowes requested review from reedsa, fselmo and pacrob April 12, 2024 16:37
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@kclowes kclowes merged commit 39e91ea into ethereum:v6 Apr 12, 2024
99 checks passed
@kclowes kclowes deleted the upper-pin-eth-account branch April 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants