Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 ethereum tester provider cancun support #3338

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 10, 2024

What was wrong?

Cancun support for EthereumTesterProvider is missing

How was it fixed?

  • Keep eth-tester dependency within the minor beta versions that support Cancun only.
  • Add relevant fields on types and eth-tester middleware formatters

Todo:

Cute Animal Picture

Screenshot 2024-04-04 at 15 57 55

fselmo added 5 commits April 10, 2024 11:59
- Geth still doesn't have a release out where their dev mode supports Cancun.
  This gets us a blob / Cancun test for EthereumTesterProvider within the core
  test suite while we can't yet add one to the integration test suite.
@fselmo fselmo force-pushed the v6-ethereum-tester-provider-cancun-support branch from 5ecb672 to 9882ed6 Compare April 10, 2024 22:09
@fselmo fselmo marked this pull request as ready for review April 10, 2024 22:15
@fselmo fselmo requested review from reedsa and kclowes April 10, 2024 22:15
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit a178d93 into ethereum:v6 Apr 11, 2024
99 checks passed
@fselmo fselmo deleted the v6-ethereum-tester-provider-cancun-support branch August 27, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants