[v6] Rename Contract.encodeABI -> Contract.encode_abi
#3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedsa
changed the title
Contract.encodeABI -> Contract.encode_abiContract.encodeABI -> Contract.encode_abi
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Mar 12, 2024
reedsa
force-pushed
the
v6-rename-encode-abi
branch
from
9f791c7 to
6a2fc30
Compare
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Mar 13, 2024
reedsa
force-pushed
the
v6-rename-encode-abi
branch
from
6a2fc30 to
2b9e863
Compare
reedsa
added a commit
to reedsa/web3.py
that referenced
this pull request
Mar 13, 2024
reedsa
force-pushed
the
v6-rename-encode-abi
branch
from
2b9e863 to
a4cb583
Compare
reedsa
force-pushed
the
v6-rename-encode-abi
branch
from
a4cb583 to
bf5fdfc
Compare
kclowes
approved these changes
Mar 13, 2024
|
|
||
|
|
||
| @patch("web3.eth.Contract.encodeABI", lambda w3, *args, **kwargs: (args, kwargs)) | ||
| def test_contract_encodeABI_deprecated_calls_encode_abi_with_args(w3): |
There was a problem hiding this comment.
Does this test add any new test vector? It looks like the test above tests kwargs already?
There was a problem hiding this comment.
This test expects the new method to be called with all the arguments. The @patch wraps the encode function to be able to check values for each argument.
| "0xea87152b0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000087261696e626f7773000000000000000000000000000000000000000000000000" | ||
|
|
||
| .. py:classmethod:: Contract.encodeABI(fn_name, args=None, kwargs=None, data=None) | ||
|
|
||
| .. deprecated:: 7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #3278
How was it fixed?
Updated references and deprecated the encodeABI method.
Todo:
Cute Animal Picture