Allow for configuring the request information cache size on wsV2 #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
approved these changes
Feb 7, 2024
| @@ -34,11 +34,13 @@ class PersistentConnectionProvider(AsyncJSONBaseProvider, ABC): | |||
| def __init__( | |||
| self, | |||
| request_timeout: float = DEFAULT_PERSISTENT_CONNECTION_TIMEOUT, | |||
| request_information_cache_size: int = 500, | |||
There was a problem hiding this comment.
It probably doesn't matter much, but the order of the kwargs may be confusing if anyone was using the subscription_response_queue_size. Consider adding it after subscription_response_queue_size?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Along with a PR to
v7, once #3225 is merged, will close #3219How was it fixed?
request_information_cachesize so users making a high number of requests do not run into the request information being lost for responses.1and checks a warning is issued when full.Todo:
Cute Animal Picture