use importlib.metadata for version info if >py37 #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
importlib-for-version
branch
2 times, most recently
from
c4c45f7 to
5fa656a
Compare
…n info availability
pacrob
force-pushed
the
importlib-for-version
branch
from
5fa656a to
966b253
Compare
fselmo
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Using
pkg_resourcesin python 3.12 causes an error.Closes #3186
How was it fixed?
Conditionally use the new
importlib.metadataformat for supplying version info as it will be a bit before python 3.7 support is dropped here. We don't technically support python 3.12 yet, but this is a simple enough fix.Added a basic test for version info while in there.
Todo:
Cute Animal Picture