Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run flaky async integration tests #3170

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Run flaky async integration tests #3170

merged 3 commits into from
Dec 15, 2023

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Dec 15, 2023 •
edited
Loading

What was wrong?

Geth integration async tests weren't being run. I noticed because the create_access_list tests in #3167 weren't being run.

How was it fixed?

Added to tox and circleci config.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes mentioned this pull request Dec 15, 2023
Merged
1 task
@kclowes kclowes marked this pull request as ready for review December 15, 2023 05:05
@kclowes kclowes requested review from fselmo, reedsa and pacrob December 15, 2023 17:27
fselmo
fselmo approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😓... lgtm 👍🏼

@kclowes kclowes merged commit e7b5e9e into ethereum:main Dec 15, 2023
99 checks passed
@kclowes kclowes deleted the run-async-flaky-int-tests branch December 15, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@reedsa reedsa Awaiting requested review from reedsa

@pacrob pacrob Awaiting requested review from pacrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @fselmo