Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump and pin mypy to latest version that supports py37 #3122

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

pacrob
Copy link
Contributor

@pacrob pacrob commented Oct 11, 2023

What was wrong?

mypy was mistakenly given only a lower-bound, should have been pinned, and its new 1.6.0 release introduced a change that breaks CI.

How was it fixed?

Pinned to latest version that still supports py37, 1.4.1

Todo:

Cute Animal Picture

image

@pacrob pacrob force-pushed the bump-and-pin-mypy branch from 77a40cc to 56694e3 Compare October 11, 2023 13:53
@pacrob pacrob requested review from reedsa and fselmo October 11, 2023 13:54
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@pacrob pacrob merged commit a821dde into ethereum:main Oct 11, 2023
1 check passed
@pacrob pacrob deleted the bump-and-pin-mypy branch October 11, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants