Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
rpc_gas_price_strategy
incorrectly returns the hex value without convesion toint
even though the defined return type isWei
.int
and only convert tohex
if it is anint
in thegas_price_strategy_middleware
.How was it fixed?
rpc_gas_price_strategy
, use theeth
modulegas_price
call which always returns anint
, rather thanrequest_blocking
which can be variable depending on the provider.gasPrice
value from strategy tohex
only if it's anint
int
, even though most providers return thehex
value.Todo:
Cute Animal Picture