Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to Release Notes about 6.6.0 and v5 EOL #3045

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jul 13, 2023

What was wrong?

v6.6.0 got yanked from Pypi, and v5 is approaching its' end-of-life.

How was it fixed?

Added a couple quick notes to the Release notes doc.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review July 13, 2023 18:10
@kclowes kclowes requested review from reedsa, fselmo, wolovim and pacrob July 14, 2023 15:17
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -27,7 +34,7 @@ Breaking Changes
Bugfixes
~~~~~~~~

- Handle `None` in the formatting middleware (`#2546 <https://github.com/ethereum/web3.py/issues/2546>`__)
- Handle ``None`` in the formatting middleware (`#2546 <https://github.com/ethereum/web3.py/issues/2546>`__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the formatting in here!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 👍🏼

@kclowes kclowes merged commit 6d54025 into ethereum:main Jul 14, 2023
@kclowes kclowes deleted the add-note-to-660 branch July 14, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants