Bugfix: AsyncWeb3.solidity_keccak no longer throws #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
fix-solidity-keccak
branch
from
d314e11 to
484abcf
Compare
kclowes
changed the title
kclowes
force-pushed
the
fix-solidity-keccak
branch
from
484abcf to
52b11cc
Compare
fselmo
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
lgtm 👍🏼
It looks like a test_async_solidity_keccak_ens() passes when I add it in locally... but should we add tests for that too? Although I think we could benefit from an AsyncWeb3ModuleTest class altogether, which would be beyond the scope of this PR. Maybe we go that route instead?
Good call. I added a parametrization for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
AsyncWeb3.solidity_keccakwas raisingTypeError: 'cytoolz.functoolz.curry' object is not iterable. The root was thenormalize_valuesfunction on theBaseWeb3class.Closes #3006
How was it fixed?
Took the
normalize_valuesfunction from theWeb3class and moved it up to theBaseWeb3class so that bothAsyncWeb3andWeb3use the same function now. Also added a test toTodo:
Cute Animal Picture