Pre-release check for upstream configuration of remote #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
I like this check better, thank you! When you get a chance, will you also PR against ethereum/ethereum-python-project-template so we can standardize? We can swap web3.py for <REPO_NAME> in the command:
git remote -v | grep "upstream\[email protected]:ethereum/<REPO_NAME>.git (push)"
so that our .project_template/refill_template_variables.py script will fill it in for each library.
fselmo
reviewed
Jun 8, 2023
reedsa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The release make command was not working, which led to running the tagging/release steps manually.
How was it fixed?
Changed the command to check the remote upstream is configured. It checks the remote repo configuration with
git remote -vand greps for the web3.py repo is set as the upstream with ssh or https.Cute Animal Picture