Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip and virtualenv for CI builds #2927

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

prathmeshranaut
Copy link
Contributor

@prathmeshranaut prathmeshranaut commented Apr 23, 2023

What was wrong?

  • circleci image tox versions were clashing with the new virtualenv release. Make sure to --upgrade the tox version sitting in the image before running tox.
  • Also, --upgrade the pip version sitting in the image python install before any of the above steps.

How was it fixed?

Todo:

Cute Animal Picture

images

@prathmeshranaut prathmeshranaut force-pushed the prathmeshranaut/fix-ci-builds branch from 0dcc3d8 to 3f7d9bf Compare April 23, 2023 18:02
@prathmeshranaut
Copy link
Contributor Author

@fselmo I faced CI failures similar to what I faced in py-evm. So I raised a similar PR as your PR in py-evm.

@prathmeshranaut prathmeshranaut force-pushed the prathmeshranaut/fix-ci-builds branch from 3f7d9bf to 7f4e235 Compare April 24, 2023 17:54
@pacrob pacrob merged commit 09baffc into ethereum:master Apr 24, 2023
@pacrob
Copy link
Contributor

pacrob commented Apr 24, 2023

Looks great, @prathmeshranaut ! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants