Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a new-to-eth banner #2905

Merged
merged 1 commit into from
Apr 7, 2023
Merged

docs: add a new-to-eth banner #2905

merged 1 commit into from
Apr 7, 2023

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Apr 6, 2023 •
edited
Loading

What was wrong?

lack of gm

How was it fixed?

  • gm added
  • welcome banner for first-timers
  • when future changes desired, thought it would be more intuitive for the ToC to live in a dedicated file

Screenshot 2023-04-06 at 4 34 03 PM

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

kclowes
kclowes approved these changes Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates!

@wolovim wolovim merged commit 8895bfc into ethereum:master Apr 7, 2023
@wolovim wolovim deleted the docs-welcome branch April 7, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolovim @kclowes