Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eth-abi requirement to v4 stable #2886

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Upgrade eth-abi requirement to v4 stable #2886

merged 1 commit into from
Mar 22, 2023

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Mar 20, 2023 •
edited
Loading

What was wrong?

eth-abi v4.0.0 is out, so we no longer need to require beta.

How was it fixed?

Require eth-abi >=4.0.0 in setup.py

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the update-eth-abi branch 2 times, most recently from eb51956 to dd1377b Compare March 22, 2023 17:12
@kclowes kclowes changed the title Test out eth-abi v4b3 Upgrade eth-abi requirement to v4 stable Mar 22, 2023
@kclowes kclowes marked this pull request as ready for review March 22, 2023 17:38
@kclowes kclowes requested review from fselmo and pacrob March 22, 2023 17:54
pacrob
pacrob approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

fselmo
fselmo approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think any new features were introduced between the "stable" beta and the actual stable release, right? So maybe an internal newfragment? Either way lgtm 👍🏼

@kclowes
Copy link
Collaborator Author

kclowes commented Mar 22, 2023

Good point - yeah, nothing was changed between v4-beta.3 and stable. Will update newsfragment!

@kclowes kclowes merged commit 29d7af6 into ethereum:master Mar 22, 2023
@kclowes kclowes deleted the update-eth-abi branch March 22, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

@fselmo fselmo fselmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kclowes @fselmo @pacrob