Add async eth.replace_transaction #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3243eric
force-pushed
the
async-replace_transaction
branch
4 times, most recently
from
3da7bde to
12099fd
Compare
e3243eric
added a commit
to e3243eric/web3.py
that referenced
this pull request
Feb 24, 2023
e3243eric
added a commit
to e3243eric/web3.py
that referenced
this pull request
Feb 24, 2023
e3243eric
force-pushed
the
async-replace_transaction
branch
from
e75399c to
68cfdca
Compare
e3243eric
force-pushed
the
async-replace_transaction
branch
from
68cfdca to
2425352
Compare
e3243eric
commented
Feb 24, 2023
| } | ||
| txn_hash = await async_w3.eth.send_transaction(txn_params) | ||
| try: | ||
| async_w3.geth.miner.start() # type: ignore |
There was a problem hiding this comment.
The AsyncGethMiner is not implemented, so I mark this test as an expected failure.
There was a problem hiding this comment.
The go-ethereum miner namespace is now deprecated, but I can help implement it if needed, just like the other async Geth namespaces.
e3243eric
commented
Feb 24, 2023
| @@ -219,7 +223,7 @@ def assert_valid_transaction_params(transaction_params: TxParams) -> None: | |||
|
|
|||
|
|
|||
| def prepare_replacement_transaction( | |||
| w3: "Web3", | |||
| w3: Union["Web3", "AsyncWeb3"], | |||
There was a problem hiding this comment.
The prepare_replacement_transaction doesn't use any async method, so I just reuse the sync version of prepare_replacement_transaction. I'm unsure if it is better to reuse it this way or copy it to async_transactions.py.
There was a problem hiding this comment.
I think leaving it here is the better option. Thanks!
kclowes
approved these changes
Apr 6, 2023
| @@ -219,7 +223,7 @@ def assert_valid_transaction_params(transaction_params: TxParams) -> None: | |||
|
|
|||
|
|
|||
| def prepare_replacement_transaction( | |||
| w3: "Web3", | |||
| w3: Union["Web3", "AsyncWeb3"], | |||
There was a problem hiding this comment.
I think leaving it here is the better option. Thanks!
This was referenced Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2824. The
replace_transactionmethod is unavailable on theAsyncEthclass.How was it fixed?
Add the
replace_transactionmethod to theAsyncEthclass, and add corresponding tests.Todo:
Cute Animal Picture