Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change eth_call return type to reflect pythonic formatter conver… #2842

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Feb 23, 2023

What was wrong?

closes #2836

How was it fixed?

  • More accurately define the return type for eth_call as HexBytes

Todo:

Cute Animal Picture

20230223_091940

- Pythonic result formatters convert ``eth_call`` response to ``HexBytes``. Due to differences between the ``HexBytes.hex()`` method and the ``bytes.hex()`` method, the former more accurately represents the type that is returned.
@fselmo fselmo marked this pull request as ready for review February 23, 2023 16:22
@fselmo fselmo requested review from kclowes and pacrob February 23, 2023 16:23
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fselmo fselmo merged commit a983bb2 into ethereum:master Feb 23, 2023
@fselmo fselmo deleted the bugfix-eth-call-return-type branch February 23, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The return type of eth_call should be HexBytes instead of bytes
3 participants