Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebrand to lowercase web3.py #2804

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Feb 3, 2023

What was wrong?

the capital W is decidedly not hip; needed rectifying immediately

Todo:

Cute Animal Picture

A Python library for interacting with Ethereum, inspired by [web3.js](https://github.com/ethereum/web3.js).
A Python library for interacting with Ethereum.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for posterity: indeed, original inspiration from web3.js (:salute:), but in the ongoing development of web3.py, that lib is no longer referenced on any regular basis, at least not any more than ethers or another language implementation.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I didn't realize Web3.py had been so standardized.

docs/conf.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

I found one more if you want tiny nit in your life 😆

@wolovim wolovim merged commit 1b8f7ad into ethereum:master Feb 7, 2023
@wolovim wolovim deleted the lowercase-rebrand branch February 7, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants