Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix abi alignment for multidimensional arrays #2764

Merged
merged 4 commits into from
Dec 18, 2022
Merged

Conversation

votrumar
Copy link

@votrumar votrumar commented Dec 18, 2022

What was wrong?

When an abi with multidimensional array was encoded, the produced value was wrong.

How was it fixed?

Small change for the recursive call of _align_abi_input. The method did not take into account the scenario of multidimensional input.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo merged commit 39859aa into ethereum:master Dec 18, 2022
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skokan 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants