Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use build for build commands. #2714

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Use build for build commands. #2714

merged 1 commit into from
Feb 24, 2023

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Nov 11, 2022 •
edited
Loading

What was wrong?

Remove direct invocations of setup.py

How was it fixed?

  • Removed direct invocations of setup.py and replaced with python -m build
  • Use circleci orb [email protected] which uses py310 + change tox path to reflect this new path in config.yml
  • Consolidate tox.ini testenvs

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the do-not-invoke-setup-py-directly branch 9 times, most recently from d451a63 to 81ad5f5 Compare November 16, 2022 00:28
@fselmo fselmo force-pushed the do-not-invoke-setup-py-directly branch 18 times, most recently from c9e24d8 to 0c905e8 Compare February 24, 2023 00:33
@fselmo
Use python -m build; do not invoke setup.py directly
b9ad4f7 
- use ``python -m build`` instead of invoking ``setup.py`` directly as the latter is strongly discouraged.
- invoke ``tox`` correctly for windows circleci job.
- consolidate commands in ``tox.ini``
- use circleci orb [email protected] which uses python 3.10 + update the python path in config.yml to reflect this
@fselmo fselmo force-pushed the do-not-invoke-setup-py-directly branch from 0c905e8 to b9ad4f7 Compare February 24, 2023 00:33
@fselmo fselmo marked this pull request as ready for review February 24, 2023 00:40
@fselmo fselmo requested review from kclowes and pacrob February 24, 2023 00:40
kclowes
kclowes approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! Looks good to me! :shipit:

@fselmo fselmo merged commit b177f97 into ethereum:master Feb 24, 2023
@fselmo fselmo deleted the do-not-invoke-setup-py-directly branch April 25, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

@pacrob pacrob Awaiting requested review from pacrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fselmo @kclowes