Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async get_block_tx_count #2687

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Oct 20, 2022

What was wrong?

Missing async w3.eth.get_block_transaction_count

How was it fixed?

Added it!

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the async-get-block-tx-count branch 5 times, most recently from 7aefcea to bdc87b4 Compare October 27, 2022 18:02
@kclowes kclowes marked this pull request as ready for review October 27, 2022 18:14
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

web3/eth.py Outdated Show resolved Hide resolved
@kclowes kclowes force-pushed the async-get-block-tx-count branch from e7f75c7 to 2bb2ce0 Compare December 1, 2022 18:37
@kclowes kclowes merged commit 2dd99be into ethereum:master Dec 1, 2022
@kclowes kclowes deleted the async-get-block-tx-count branch December 1, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants