Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin importlib-metadata<5 on Python 3.7 #2671

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Pin importlib-metadata<5 on Python 3.7 #2671

merged 2 commits into from
Oct 7, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Oct 7, 2022 •
edited
Loading

What was wrong?

PRs started failing on python 3.7 builds.

Related to Issue #

How was it fixed?

Pin importlib-metadata<5 on versions of python less than 3.7.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review October 7, 2022 17:52
@kclowes kclowes requested review from fselmo and pacrob October 7, 2022 17:52
fselmo
fselmo approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@kclowes kclowes merged commit 5f64595 into ethereum:master Oct 7, 2022
@kclowes kclowes deleted the importlib-metadata branch October 7, 2022 18:13
@ofek ofek mentioned this pull request Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fselmo fselmo fselmo approved these changes

@pacrob pacrob Awaiting requested review from pacrob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @fselmo