Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin protobuf to 3.19.4 for now: #2659

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Sep 22, 2022

What was wrong?

Closes #2654
v5 backport of #2657 with the exception that protobuf version 3.19.4 was the last non-breaking supported 3.x version for python 3.6 which web3.py v5 still supports.

How was it fixed?

See: #2657

Todo:

Cute Animal Picture

20220918_174958

@fselmo fselmo force-pushed the v5-update-protobuf branch 2 times, most recently from 386fac5 to 4657f43 Compare September 22, 2022 17:35
@fselmo fselmo changed the title Pin protobuf to 3.20.1 for now: Pin protobuf to 3.19.5 for now: Sep 22, 2022
@fselmo fselmo changed the title Pin protobuf to 3.19.5 for now: Pin protobuf to 3.18.3 for now: Sep 22, 2022
@fselmo fselmo force-pushed the v5-update-protobuf branch 3 times, most recently from 2658087 to 6ca378d Compare September 22, 2022 17:57
@fselmo fselmo marked this pull request as ready for review September 22, 2022 17:59
@fselmo fselmo requested a review from pacrob September 22, 2022 17:59
@fselmo fselmo changed the title Pin protobuf to 3.18.3 for now: Pin protobuf to 3.19.4 for now: Sep 22, 2022
- see: protocolbuffers/protobuf#10051
- ``3.19.4`` is the latest non-breaking supported version for python ``3.6`` which is still supported in ``v5```
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fselmo fselmo merged commit 50c83b9 into ethereum:v5 Sep 22, 2022
@fselmo fselmo deleted the v5-update-protobuf branch April 3, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants