[v5] Add support for safe and finalized block identifiers
#2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
changed the title
safe and finalized block identifierssafe and finalized block identifiers
fselmo
force-pushed
the
v5-new-block-identifiers
branch
from
a2d4431 to
c40adf2
Compare
- ``safe`` and ``finalized`` is sometimes accepted and sometimes not when it comes to filters. They are not yet part of the specifications so the documentation should reflect this. However, when creating event filters for example, these are supported block ids in Infura and they do yield different results than, say, "latest". Because of this, we should support it but provide careful documentation that they may or may not yield desirable results.
fselmo
force-pushed
the
v5-new-block-identifiers
branch
from
c40adf2 to
81becd8
Compare
wolovim
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Closes #2641
v5version of PR #2652Note: I didn't add the integration tests here because we don't expect to update
v5test fixtures to post-merge. Only the relevant tests from PR #2652 were added.Todo:
Cute Animal Picture