Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snakecase toWei and fromWei #2647

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Sep 14, 2022

What was wrong?

Inherited javascript syntax. This PR does not include a deprecation step, intended for v6.
Related to #2598

Todo:

Cute Animal Picture

@wolovim wolovim force-pushed the snake-case-wei-helpers branch from f37a12d to 1e18678 Compare September 14, 2022 16:41
@wolovim wolovim requested a review from kclowes September 14, 2022 17:23
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 !

@wolovim wolovim merged commit 086c1a8 into ethereum:master Sep 14, 2022
@wolovim wolovim deleted the snake-case-wei-helpers branch September 14, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants