Remove WEB3_INFURA_API_KEY environment variable in favor of WEB3_INFURA_PROJECT_ID #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
approved these changes
Sep 8, 2022
kclowes
force-pushed
the
remove-w3-infura-api-key
branch
from
ef18e8b to
e6197ea
Compare
kclowes
force-pushed
the
remove-w3-infura-api-key
branch
from
e6197ea to
45869ee
Compare
pacrob
reviewed
Sep 9, 2022
There was a problem hiding this comment.
Line 221 in 845bce4
There's still an exception InfuraKeyNotFound - should that change to InfuraIdNotFound or similar?
|
Good call, @pacrob. Will update that too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Another v6 breaking change. We had 2 environment variables that were aliases of one another for backwards compatibility.
How was it fixed?
Standardized on WEB3_INFURA_PROJECT_ID to match up with Infura's wording.
Todo:
Cute Animal Picture