Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence IPFS unauthorized call errors for now #2603

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Silence IPFS unauthorized call errors for now #2603

merged 1 commit into from
Aug 10, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Aug 10, 2022 •
edited
Loading

What was wrong?

Infura IPFS calls need authentication as of today. Related thread: https://community.infura.io/t/ipfs-authentication-error-403-forbidden/5672/18

How was it fixed?

  • Infura IPFS call errors were silenced for now until we can add the proper authentication

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the silence-ipfs-unauthorized-errors branch from 55c5c29 to 57f40fb Compare August 10, 2022 21:38
@fselmo fselmo marked this pull request as ready for review August 10, 2022 21:39
@fselmo fselmo changed the title [WIP] Silence IPFS unauthorized call errors for now Silence IPFS unauthorized call errors for now Aug 10, 2022
kclowes
kclowes approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will you also add an issue to wire up the authorization instead of silencing these when you get a chance?

@fselmo
Copy link
Collaborator Author

fselmo commented Aug 10, 2022

LGTM! Will you also add an issue to wire up the authorization instead of silencing these when you get a chance?

👍🏼 Done: #2604

@fselmo fselmo merged commit 5aad062 into ethereum:master Aug 10, 2022
This was referenced Aug 10, 2022
Merged
Closed
@fselmo fselmo deleted the silence-ipfs-unauthorized-errors branch April 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fselmo @kclowes