Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'account' to AsyncEth? #2580

Closed
ChristianCoenen opened this issue Jul 19, 2022 · 3 comments · Fixed by #2582
Closed

Add 'account' to AsyncEth? #2580

ChristianCoenen opened this issue Jul 19, 2022 · 3 comments · Fixed by #2582

Comments

@ChristianCoenen
Copy link

ChristianCoenen commented Jul 19, 2022 •
edited
Loading

Hey 👋 Is there a reason account is not available in AsyncEth?

So far, I had to create a non-async w3 object to sign transactions. However, I just found out that when I subclass AsyncEth like this

class CustomAsyncEth(AsyncEth):
    account = Account()

signing transactions works just fine.
@ChristianCoenen ChristianCoenen changed the title Asyncify account module Add 'account' to AsyncEth? Jul 19, 2022
@kclowes
Copy link
Collaborator

kclowes commented Jul 20, 2022

No reason other than we haven't gotten there yet :) I'll leave this open to track account specifically. Feel free to PR the change if you have the time, otherwise know that it's in our queue!

@dbfreem dbfreem mentioned this issue Jul 21, 2022
Merged
1 task
@dbfreem
Copy link
Contributor

dbfreem commented Jul 21, 2022

I went ahead and added this since it was an easy fix. It's in PR #2582

@fselmo
Copy link
Collaborator

fselmo commented Jul 29, 2022

closed by #2582 (v6) and #2590 (v5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved account to BaseEth dbfreem/web3.py
4 participants
@fselmo @kclowes @dbfreem @ChristianCoenen