Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black to the ENS module #2550

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Add black to the ENS module #2550

merged 2 commits into from
Jul 7, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jul 1, 2022

What was wrong?

Need to add black linting to the ENS module

Related to Issue #2519

How was it fixed?

added the /ens path to black and ran it!

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes marked this pull request as ready for review July 1, 2022 21:56
@kclowes kclowes requested review from fselmo and pacrob July 1, 2022 21:56
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgm after resolving the conflicts in tox.ini 👍

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit 05fb86a into ethereum:master Jul 7, 2022
@kclowes kclowes deleted the add-black-ens branch July 7, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants