Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc build #2472

Merged
merged 2 commits into from
May 16, 2022
Merged

fix doc build #2472

merged 2 commits into from
May 16, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented May 13, 2022 •
edited
Loading

What was wrong?

I'm not sure, but I think a bad rebase started making the docs build fail on the v5 branch.

Related to Issue #2470

How was it fixed?

Moved the python 3.6 image back to circleci/python3.6 rather than cimg/python3.6

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes requested a review from pacrob May 13, 2022 20:43
pacrob
pacrob approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kclowes kclowes merged commit b7fc8b0 into ethereum:v5 May 16, 2022
@kclowes kclowes deleted the fix-doc-build branch May 16, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kclowes @pacrob