deprecated estimateGas and buildTransaction in v5 contract #2438

[dbfreem]

Deprecating buildTransaction and estimateGas in the v5 branch. I will remove them in the asyncify-contract branch so they are effectively removed in v6

Related to Issue #1416

Todo:

• Add entry to the release notes

[dbfreem]

@kclowes take a look at this PR. I closed my other PR because I accidently pulled from master and REALLY messed it up.

[dbfreem]

I fixed the issue with the combomethod annotation. Also, @kclowes I took care of the warnings in the test in the asyncify-contract branch already so I was going to leave these. thoughts??

[kclowes]

Also, @kclowes I took care of the warnings in the test in the asyncify-contract branch already so I was going to leave these. thoughts??

For deprecations, we prefer to change all of the instances of our code over to the new function name and then have one test to be sure the deprecation warning gets shown just so that we don't have a bunch of noise in our test output. For example something like:

def test_that_deprecation_warning_is_shown():
    ...
    with pytest.warns("DeprecationWarning", match="estimateGas has been deprecated in favor of estimate_gas")
        contract.functions.foo().estimateGas()

[dbfreem]

@kclowes makes sense I will take a look at this.

[dbfreem]

@kclowes this one should be good to go now.

[kclowes]

Looks good to me! I left a few questions, but after those are addressed, should be good to go!

[dbfreem]

This should be good to go

[kclowes]

Thank you! This looks good to me! I'm going to change the newsfragment from misc to feature just so it gets highlighted in the release notes. Any miscs only show up as the PR number.