Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v6 warnings to ENS changes from pr #2411 #2452

Merged
merged 3 commits into from
Jun 11, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Apr 29, 2022

What was wrong?

Method signature changes and method deprecation for some ENS methods in v6.

Related to Issue #2411

How was it fixed?

Add warnings for method deprecation and method signature changes for ENS methods in v6.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think I found a few typos in the error message and added a longer comment that you can feel free to take or leave!

ens/main.py Outdated Show resolved Hide resolved
tests/ens/test_v6_warnings.py Outdated Show resolved Hide resolved
ens/main.py Show resolved Hide resolved
@fselmo fselmo force-pushed the ens-v6-warnings branch from 05bf3ac to b303309 Compare May 3, 2022 16:09
@fselmo fselmo requested a review from kclowes May 3, 2022 16:10
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's taken me so long to get to this! I added one comment, but looks good otherwise!

ens/main.py Outdated Show resolved Hide resolved
@fselmo fselmo requested a review from kclowes June 7, 2022 20:46
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ! LGTM!

@fselmo fselmo force-pushed the ens-v6-warnings branch from 1aab1b2 to bdad9e4 Compare June 11, 2022 19:08
@fselmo fselmo merged commit b1e23b3 into ethereum:v5 Jun 11, 2022
fselmo added a commit that referenced this pull request Jun 11, 2022
@fselmo fselmo deleted the ens-v6-warnings branch June 11, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants