-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v6 warnings to ENS changes from pr #2411 #2452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think I found a few typos in the error message and added a longer comment that you can feel free to take or leave!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it's taken me so long to get to this! I added one comment, but looks good otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
! LGTM!
What was wrong?
Method signature changes and method deprecation for some ENS methods in
v6
.Related to Issue #2411
How was it fixed?
Add warnings for method deprecation and method signature changes for ENS methods in
v6
.Todo:
Cute Animal Picture