Cache eth.chain_id in simple_cache_middleware #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will add async chainId to the cache once the simple_cache_middleware is available on async
kclowes
changed the title
fselmo
approved these changes
Apr 13, 2022
kclowes
added a commit
to kclowes/web3.py
that referenced
this pull request
Apr 13, 2022
* Add caching for sync chain_id * Remove async chainId setter Will add async chainId to the cache once the simple_cache_middleware is available on async * Add docs * Add newsfragment for simple_cache_middleware, take out old, confusing newsfragment
1 task
kclowes
added a commit
that referenced
this pull request
Apr 27, 2022
* Cache eth.chain_id in simple_cache_middleware (#2425) * Add caching for sync chain_id * Remove async chainId setter Will add async chainId to the cache once the simple_cache_middleware is available on async * Add docs * Add newsfragment for simple_cache_middleware, take out old, confusing newsfragment
pacrob
pushed a commit
that referenced
this pull request
May 23, 2022
* Cache eth.chain_id in simple_cache_middleware (#2425) * Add caching for sync chain_id * Remove async chainId setter Will add async chainId to the cache once the simple_cache_middleware is available on async * Add docs * Add newsfragment for simple_cache_middleware, take out old, confusing newsfragment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
It was not ideal to have to set
_default_chain_id=Noneto make thechain_idrequest again. Added the syncchain_idto thesimple_cache_middlewareinstead. Our benchmarking suite shows times of ~.003s afterchain_idis cached, which is down from ~.017s.How was it fixed?
Added
eth_chainIdto thesimple_cache_middleware. Had to take out the async_default_chain_idflow for consistency between the two modules, and will add caching for asyncchain_idafter thesimple_cache_middlewaregets asyncified.Todo:
Cute Animal Picture