Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Geth Integration test WebsocketProvider timeout to 30s #2260

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Dec 15, 2021

What was wrong?

More flaky tests.

How was it fixed?

Bumped the timeout a little bit more.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍

@kclowes kclowes merged commit de4cc86 into ethereum:master Dec 16, 2021
@kclowes kclowes deleted the bump-ws-30 branch December 16, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants