Remove default gasPrice when 1559 params present #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
remove-default-gas-price
branch
from
135b8b9 to
c4aed54
Compare
fselmo
commented
Jul 29, 2021
| @@ -277,7 +280,6 @@ def test_signed_transaction( | |||
|
|
|||
| if isinstance(expected, type) and issubclass(expected, Exception): | |||
| with pytest.raises(expected): | |||
| start_balance = w3.eth.get_balance(_transaction.get('from', w3.eth.accounts[0])) | |||
There was a problem hiding this comment.
This is just cleanup. This line was not used anywhere.
fselmo
force-pushed
the
remove-default-gas-price
branch
14 times, most recently
from
f611e2e to
f36066b
Compare
fselmo
changed the title
fselmo
force-pushed
the
remove-default-gas-price
branch
2 times, most recently
from
055c052 to
e85eb62
Compare
kclowes
approved these changes
Aug 2, 2021
fselmo
force-pushed
the
remove-default-gas-price
branch
from
e85eb62 to
2d334a1
Compare
Do not set a default 'gasPrice' if 1559 params are present and default to transaction 'type' of '0x2' if 1559 params are present.
fselmo
force-pushed
the
remove-default-gas-price
branch
from
2d334a1 to
fe489a5
Compare
fselmo
force-pushed
the
remove-default-gas-price
branch
from
fe489a5 to
abdc653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
sign_and_send_raw_middlewarewas broken for EIP-1559 transactions since it made use offill_transaction_defaults()and this was always adding agasPriceif none was present. This would cause both legacy and 1559 params to be present leading to errors.How was it fixed?
fill_transaction_defaults(), removed the default value forgasPricewhen 1559 parameters are present. This keeps things backwards compatible and also provides support for 1559 for the signing middleware.fill_transaction_defaults()also defaults the transactiontypeto'0x2'when 1559 params are present as this implies a 1559-style transaction. This is important because transaction signing (done viaeth-account) relies on thetypefor validating 1559 transactions. We don't require thetypeforsend_transactionso this makes the user experience smoother when using this middleware since they may already be used to sending transactions without providing atype.Todo:
Cute Animal Picture