Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-1559 gas price / fee history oracles #2054

Closed
wolovim opened this issue Jun 28, 2021 · 2 comments
Closed

EIP-1559 gas price / fee history oracles #2054

wolovim opened this issue Jun 28, 2021 · 2 comments

Comments

@wolovim
Copy link
Member

wolovim commented Jun 28, 2021

Pre-London (legacy) transactions rely on a gasPrice to be set by the user or determined by Web3.py or the client. Post-London transactions drop gasPrice in favor of maxFeePerGas and maxPriorityFeePerGas.

Questions:

  • Will eth_gasPrice continue to be supported for legacy transactions as is?
    • Geth will continue to return total fees paid (tip + base)
  • Should Web3.py continue to offer gas price strategies for legacy transactions? Support both legacy and new transactions? Just new txs?
    • TBD
  • Should a new oracle fee API return both a maxFeePerGas and a maxPriorityFeePerGas, or just the latter?
    • New RPC method, eth_maxPriorityFeePerGas available after London. Effectively returns eth_gasPrice - baseFee. Geth shoots for 60th percentile as the price suggestion to keep downward pressure on the price.
  • What are optimal defaults for maxFeePerGas and maxPriorityFeePerGas if we don't just let the client decide? Or should that be the responsibility of the client?
    • Geth: "If the user doesn't specify maxFeePerGas, we default to maxPriorityFeePerGas + 2*baseFee"

Resources:

Things that may update in Web3.py:

  • generate_gas_price API
  • gas_strategies
  • gas_price_strategy middleware
  • gas_price.rst docs pages
  • new APIs for maxFeePerGas and/or maxPriorityFeePerGas
@banteg
Copy link
Contributor

banteg commented Aug 9, 2021

I added eth_maxPriorityFeePerGas in #2100. Tested with devel version of Erigon.

@L-F-Escobar
Copy link

beautiful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants