Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eth_getRawTransactionByHash #2039

Closed
kclowes opened this issue Jun 18, 2021 · 3 comments
Closed

Add eth_getRawTransactionByHash #2039

kclowes opened this issue Jun 18, 2021 · 3 comments
Assignees
@Moras-del
Labels
Good First Issue

Comments

@kclowes
Copy link
Collaborator

kclowes commented Jun 18, 2021

What was wrong?

We don't have support for the eth_getRawTransactionByHash RPC method.

How can it be fixed?

Add it to BaseEth, and add it to both Eth and AsyncEth following established patterns. Tests will need to be added as well.
@Moras-del
Copy link
Contributor

Hello! I would like to work on this. Could you assign this task to me? :)

@kclowes
Copy link
Collaborator Author

kclowes commented Jun 23, 2021

Done! Let me know if you need any guidance! PR-ing early and often is best! Thanks!

@Moras-del Moras-del mentioned this issue Jun 24, 2021
Merged
@kclowes
Copy link
Collaborator Author

kclowes commented Aug 9, 2021

Fixed in #2051

@kclowes kclowes closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Moras-del Moras-del

Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kclowes @Moras-del