Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade websockets to >=9.1.0 #2029

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Jun 11, 2021

What was wrong?

Websockets needed to be upgraded!

How was it fixed?

Upgraded websockets to >=9.1.0, <10

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes force-pushed the update-websockets branch 2 times, most recently from 987eb03 to c56e9d2 Compare June 15, 2021 05:21
@dixonwhitmire
Copy link

Hello! This dependency update will help us resolve a build issue we have with one of our applications. Please let me know if our team can help with this effort!

Thanks!

@kclowes
Copy link
Collaborator Author

kclowes commented Jun 17, 2021

@dixonwhitmire thanks for the offer! Once I get CI working this should be good to go!

@dixonwhitmire
Copy link

dixonwhitmire commented Jun 17, 2021

@dixonwhitmire thanks for the offer! Once I get CI working this should be good to go!

Thank you very much! We will be happy to assist with testing once the change is available.

@kclowes kclowes force-pushed the update-websockets branch 2 times, most recently from 25ae498 to 41a6876 Compare June 17, 2021 22:51
@kclowes kclowes changed the title [WIP] Upgrade websockets to >=9.1.0 Upgrade websockets to >=9.1.0 Jun 17, 2021
@kclowes kclowes force-pushed the update-websockets branch from 41a6876 to 3f2de42 Compare June 17, 2021 22:55
@kclowes kclowes requested review from wolovim and fselmo June 17, 2021 23:00
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this workaround for the docs_steps to install web3 within a separate step should be good for now! maybe we can revisit this at some point

@kclowes kclowes force-pushed the update-websockets branch from deee1e9 to 3f2de42 Compare June 25, 2021 20:36
@kclowes kclowes merged commit 5f83154 into ethereum:master Jun 25, 2021
@kclowes kclowes deleted the update-websockets branch June 25, 2021 20:39
@dixonwhitmire
Copy link

@kclowes - thank you for updating the websocket dependency!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants