Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support state_override in contract function call #2005

Merged
merged 1 commit into from
May 27, 2021

Conversation

zzh1996
Copy link
Contributor

@zzh1996 zzh1996 commented May 26, 2021

What was wrong?

state_override is not supported in contract function call.

How was it fixed?

state_override is accepted in contract function call and passed to web3.eth.call

Todo:

@zzh1996 zzh1996 marked this pull request as ready for review May 26, 2021 16:23
@zzh1996 zzh1996 changed the title support state_override in contract function call Support state_override in contract function call May 26, 2021
@kclowes
Copy link
Collaborator

kclowes commented May 26, 2021

Thanks for the contribution! This looks good to me on first glance, but I want to test it manually before merging since eth-tester doesn't support state_override.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test and everything looks good here! Thanks @zzh1996!

@kclowes kclowes merged commit 474a7ef into ethereum:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants