AsyncHTTPProvider accepts middleware #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
async-gas-price-middleware
branch
from
a47f0f1 to
13da9e8
Compare
kclowes
changed the title
pipermerriam
approved these changes
May 24, 2021
There was a problem hiding this comment.
I wasn't able to glean "why" this middleware is being applied at the provider level rather than the web3 level. Otherwise, this looks structurally good. Still probably worth getting a quick review from @marcgarreau as I didn't use my fine-toothed-comb
wolovim
approved these changes
May 28, 2021
kclowes
force-pushed
the
async-gas-price-middleware
branch
from
8674d94 to
7788c2d
Compare
kclowes
force-pushed
the
async-gas-price-middleware
branch
from
7788c2d to
860142a
Compare
kclowes
changed the title
kclowes
force-pushed
the
async-gas-price-middleware
branch
2 times, most recently
from
a36c1aa to
21a1553
Compare
kclowes
changed the title
wolovim
approved these changes
Jun 4, 2021
There was a problem hiding this comment.
thanks for benchmarking! huge difference in sendTransaction; we may need to scale down the number of calls there.
appreciate the import warning too. still looks sane after the updates, and plenty of time to keep feeling out if we've got the API and code location right before we call it 'stable'. 
kclowes
force-pushed
the
async-gas-price-middleware
branch
from
9ca55da to
726d84d
Compare
This was referenced Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The Async RPC provider didn't accept any middleware.
Related to Issue #1987, #1988, #2000
How was it fixed?
Added the ability for the AsyncHTTPProvider to accept middleware and added an async
gas_price_strategymiddleware to test it out. Also adds session caching, and now theEthereumTesterProviderinherits from theAsyncBaseProviderTodo:
Cute Animal Picture