Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async validation middleware #1991

Closed
kclowes opened this issue May 10, 2021 · 1 comment
Closed

Async validation middleware #1991

kclowes opened this issue May 10, 2021 · 1 comment

Comments

@kclowes
Copy link
Collaborator

kclowes commented May 10, 2021

What was wrong?

The validation middleware relies on a web3 instance to validate the chain id. In order to have a full async pathway, web3py needs an async version of the middleware that will use an async w3 instance.

How can it be fixed?

Add an async_validation_middleware that can be used in the async pathway. It looks like we may be able to take the result_formatters out of this validation middleware and put it in method_formatters.py.

This issue builds on #1986, and will depend on #1987.

@fselmo
Copy link
Collaborator

fselmo commented Jul 30, 2021

Closing in favor of #2070 which duplicates this

@fselmo fselmo closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants