Docs: Explicitly note solidityKeccak performs a packed encoding. #1971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The docs diddn't explicitly state what type of encoding
web3.solidityKeccak
performs.As of Solidity v0.5.x,
keccak256
doesn't do any automatic encoding.People less familiar with Solidity v0.4.x could find the description ambiguous.
How was it fixed?
Added to relevant docs section.
I also thought it'd be nice to add examples of the equivalent solidity (which should be valid for v0.5.x - v0.8.x at least)
Thanks! Let me know if there's any quibbles or things I can adjust.