Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate waitForTransactionReceipt in favor of snakecased wait_for_transaction_receipt #1896

Conversation

tmckenzie51
Copy link
Contributor

@tmckenzie51 tmckenzie51 commented Mar 9, 2021

What was wrong?

Added wait_for_transaction_receipt, deprecated waitForTransactionReceipt

Related to Issue #1429

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes
Copy link
Collaborator

kclowes commented Mar 11, 2021

I'm not sure if this is ready for an official review yet, but it looks like there are bunch of waitForTransactionReceipts throughout the tests that need to be swapped out still! It would also be good to add a test to make sure that the DeprecationWarning gets raised.

@tmckenzie51 tmckenzie51 force-pushed the tiffany/waitForTransReceipt-to-snakecase branch from 5fd8592 to 1a43913 Compare March 23, 2021 21:24
@tmckenzie51 tmckenzie51 force-pushed the tiffany/waitForTransReceipt-to-snakecase branch 3 times, most recently from 0c7c1a7 to e310e88 Compare March 26, 2021 15:59
@tmckenzie51 tmckenzie51 force-pushed the tiffany/waitForTransReceipt-to-snakecase branch from f45e915 to e0dc6fa Compare March 29, 2021 22:11
@tmckenzie51 tmckenzie51 requested a review from kclowes March 29, 2021 22:11
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had one nitpicky comment in the docs!

docs/web3.eth.rst Outdated Show resolved Hide resolved
@tmckenzie51 tmckenzie51 merged commit 506a302 into ethereum:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants